Skip to content

Revert black bump to unbreak lintrunner on main#20777

Merged
rascani merged 1 commit into
pytorch:mainfrom
rascani:fix-lintrunner-black-py314
Jul 7, 2026
Merged

Revert black bump to unbreak lintrunner on main#20777
rascani merged 1 commit into
pytorch:mainfrom
rascani:fix-lintrunner-black-py314

Conversation

@rascani

@rascani rascani commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

#20452 raised black from 24.4.2 to 26.3.0 so it would accept "py314" in [tool.black] target-version. That two-year jump in black's stable style would reformat ~1900 tracked files, so lintrunner --all-files fails on main under the newer style.

Revert black to 24.4.2 and drop py314 from target-version, which is a formatting-only setting and does not affect running executorch on 3.14. The rest of #20452's 3.14 support (requires-python, classifiers, wheel matrices, setup.py) is unchanged.

pytorch#20452 raised black from 24.4.2 to 26.3.0 so it would accept "py314" in
[tool.black] target-version. That two-year jump in black's stable style
would reformat ~1900 tracked files, so lintrunner --all-files fails on
main under the newer style.

Revert black to 24.4.2 and drop py314 from target-version, which is a
formatting-only setting and does not affect running executorch on 3.14.
The rest of pytorch#20452's 3.14 support (requires-python, classifiers, wheel
matrices, setup.py) is unchanged.

This was authored with Claude.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@rascani
rascani requested a review from JacobSzwejbka July 7, 2026 22:42
@pytorch-bot pytorch-bot Bot added the ci-no-td label Jul 7, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20777

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 157 Pending

As of commit 3a6d661 with merge base dcc04ef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani
rascani merged commit d658507 into pytorch:main Jul 7, 2026
208 of 213 checks passed
@rascani
rascani deleted the fix-lintrunner-black-py314 branch July 7, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants