Skip to content

Forward-fix vulkan test after XNNPACK update#20977

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D112136754
Jul 16, 2026
Merged

Forward-fix vulkan test after XNNPACK update#20977
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JakeStevens:export-D112136754

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary: Update conv2d_gemm_dynamic_test to match the bumped XNNPACK convolution operator API which removed the code_cache create argument and the reshape workspace_alignment output argument.

Reviewed By: SS-JIA

Differential Revision: D112136754

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

Summary: Update conv2d_gemm_dynamic_test to match the bumped XNNPACK convolution operator API which removed the code_cache create argument and the reshape workspace_alignment output argument.

Reviewed By: SS-JIA

Differential Revision: D112136754
@JakeStevens
JakeStevens requested a review from SS-JIA as a code owner July 16, 2026 13:34
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 16, 2026
@pytorch-bot

pytorch-bot Bot commented Jul 16, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20977

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51cb974 with merge base 43bdb7b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 16, 2026
@meta-codesync

meta-codesync Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112136754.

@SS-JIA SS-JIA left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync
meta-codesync Bot merged commit c6832c8 into pytorch:main Jul 16, 2026
209 of 216 checks passed
rstehle pushed a commit to rstehle/executorch that referenced this pull request Jul 16, 2026
Differential Revision: D112136754

Pull Request resolved: pytorch#20977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants