Skip to content

Cortex-M: add matmul_to_bmm_pass.py to the passes BUCK srcs#21042

Merged
rascani merged 1 commit into
pytorch:mainfrom
rascani:cortexm-buck-matmul-fix
Jul 20, 2026
Merged

Cortex-M: add matmul_to_bmm_pass.py to the passes BUCK srcs#21042
rascani merged 1 commit into
pytorch:mainfrom
rascani:cortexm-buck-matmul-fix

Conversation

@rascani

@rascani rascani commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

#21028 added backends/cortex_m/passes/matmul_to_bmm_pass.py and imported MatmulToBmmPass from cortex_m_pass_manager, but did not add the file to the cortex_passes python_library srcs list, so the buck build cannot resolve the import and internal builds and tests break. Add the missing source; its imports (torch, exir pass_base) are already covered by the target's deps.

pytorch#21028 added backends/cortex_m/passes/matmul_to_bmm_pass.py and imported
MatmulToBmmPass from cortex_m_pass_manager, but did not add the file to the
cortex_passes python_library srcs list, so the buck build cannot resolve the
import and internal builds and tests break. Add the missing source; its
imports (torch, exir pass_base) are already covered by the target's deps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@pytorch-bot

pytorch-bot Bot commented Jul 20, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21042

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 20, 2026
@rascani
rascani requested review from metascroy and psiddh July 20, 2026 18:02
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@rascani
rascani merged commit 2d0446b into pytorch:main Jul 20, 2026
182 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants