Preserve full_like dtype in AOT passes (#21560) - #21560
Open
ethansfng wants to merge 1 commit into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21560
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 3 PendingAs of commit f3d1712 with merge base 454f979 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ethansfng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114433185. |
This PR needs a
|
meta-codesync
Bot
changed the title
ethansfng
force-pushed
the
export-D114433185
branch
from
August 4, 2026 16:38
e3bb087 to
7fdb9d8
Compare
ethansfng
added a commit
to ethansfng/executorch
that referenced
this pull request
Aug 4, 2026
Summary: Preserve the result dtype when `ReplaceFullLikeWithFullPass` rewrites `aten.full_like` to `aten.full`, avoiding silent dtype changes in exported graphs. Add regression coverage and keep the fbcode and xplat mirrors synchronized. Differential Revision: D114433185
abeakkas
approved these changes
Aug 4, 2026
ethansfng
added a commit
to ethansfng/executorch
that referenced
this pull request
Aug 4, 2026
Summary: Preserve the result dtype when `ReplaceFullLikeWithFullPass` rewrites `aten.full_like` to `aten.full`, avoiding silent dtype changes in exported graphs. Add regression coverage and keep the fbcode and xplat mirrors synchronized. Reviewed By: abeakkas Differential Revision: D114433185
ethansfng
force-pushed
the
export-D114433185
branch
from
August 4, 2026 20:13
7fdb9d8 to
2af6687
Compare
ethansfng
added a commit
to ethansfng/executorch
that referenced
this pull request
Aug 4, 2026
Summary: Preserve the result dtype when `ReplaceFullLikeWithFullPass` rewrites `aten.full_like` to `aten.full`, avoiding silent dtype changes in exported graphs. Add regression coverage and keep the fbcode and xplat mirrors synchronized. Reviewed By: abeakkas Differential Revision: D114433185
ethansfng
force-pushed
the
export-D114433185
branch
from
August 4, 2026 21:45
2af6687 to
18999ff
Compare
Summary: Preserve the result dtype when `ReplaceFullLikeWithFullPass` rewrites `aten.full_like` to `aten.full`, avoiding silent dtype changes in exported graphs. Add regression coverage and keep the fbcode and xplat mirrors synchronized. Reviewed By: abeakkas Differential Revision: D114433185
ethansfng
force-pushed
the
export-D114433185
branch
from
August 4, 2026 22:04
18999ff to
f3d1712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Preserve the result dtype when
ReplaceFullLikeWithFullPassrewritesaten.full_liketoaten.full, avoiding silent dtype changes in exported graphs.Add regression coverage and keep the fbcode and xplat mirrors synchronized.
Reviewed By: abeakkas
Differential Revision: D114433185