Add file-backed serialization support - #21626
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21626
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 Unclassified FailuresAs of commit a01dc1a with merge base 74f1ce8 ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@claude review this code |
This PR needs a
|
|
Claude finished @metascroy's task in 3m 45s —— View job Code ReviewI reviewed the file-backed serialization changes across Correctness / lifecycle1. 2.
3. Duplicate-key check silently upgraded from byte-equality to length+SHA-256 ( Minor4. 5. 6. Looks good
Suggestions
Fix issues #1 and #2 → |
|
@claude check if current version solves your comment |
|
Claude finished @Gasoonjia's task in 1m 31s —— View job Re-review: yes, the current version resolves my earlier commentsI re-read
✅ Issue #1 — cleanup no longer relies on
|
This PR adds file-backed serialization support to ExecuTorch, allowing large named-data blobs to be hashed, deduplicated, and written in chunks without loading them entirely into memory. It also introduces backend hooks for controlling program copying and AOTI weight materialization while preserving existing behavior by default.