Skip to content

Fix test-webgpu-native: export the missing rope_hf_dynamic_sequence fixture #21690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shoumikhin wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

Fix test-webgpu-native: export the missing rope_hf_dynamic_sequence fixture #21690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test-webgpu-native.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ jobs:
runner: linux.4xlarge.memory
docker-image: ci-image:executorch-ubuntu-22.04-clang12
submodules: recursive
timeout: 120
# The test script alone runs about 60 minutes, and the checkout plus the
# Dawn and SwiftShader source builds in front of it have been measured
# between 18 and 64 minutes on this same runner type, so 120 does not
# cover a slow setup.
timeout: 150
script: |
set -eux

Expand Down
7 changes: 6 additions & 1 deletion backends/webgpu/scripts/test_webgpu_native_ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,12 @@ export_rope_model('${ROPE_DECODE_MODEL}', '${ROPE_DECODE_XQ_GOLDEN}', '${ROPE_DE
"

$PYTHON_EXECUTABLE -c "
from executorch.backends.webgpu.test.ops.test_rope_hf import export_rope_hf_dynamic
from executorch.backends.webgpu.test.ops.test_rope_hf import (
export_rope_hf_dynamic,
export_rope_hf_dynamic_sequence,
)
export_rope_hf_dynamic('${ROPE_HF_DIR}')
export_rope_hf_dynamic_sequence('${ROPE_HF_DIR}')
"

$PYTHON_EXECUTABLE -c "
Expand Down Expand Up @@ -157,6 +161,7 @@ export_incache_decode('/tmp')
"

require_file "${ROPE_HF_DIR}/rope_hf_dynamic.pte"
require_file "${ROPE_HF_DIR}/rope_hf_dynamic_sequence.pte"
require_file "${SYMINT_BLOB}"
require_file "${OUTPUT_SUPPRESSION_DIR}/input.bin"

Expand Down
4 changes: 4 additions & 0 deletions backends/webgpu/test/test_native_ci_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,9 @@ def test_requires_dynamic_rope_fixture(self) -> None:
).read_text()

self.assertIn("export_rope_hf_dynamic('${ROPE_HF_DIR}')", script)
self.assertIn("export_rope_hf_dynamic_sequence('${ROPE_HF_DIR}')", script)
self.assertIn('WEBGPU_TEST_ROPE_HF_DIR="${ROPE_HF_DIR}"', script)
self.assertIn('require_file "${ROPE_HF_DIR}/rope_hf_dynamic.pte"', script)
self.assertIn(
'require_file "${ROPE_HF_DIR}/rope_hf_dynamic_sequence.pte"', script
)
Loading