Arm backend: Reject unsupported comparisons in FP profile - #22558
Merged
Sebastian-Larsson merged 1 commit intoSep 4, 2026
Merged
Conversation
TOSA section 2.8 limits PRO-FP comparison inputs to fp16 and fp32, with bf16 provided by EXT-BF16. Allow int8 and int16 inputs legalized by the preceding pass. Reject other unsupported input types during partitioning so they remain on CPU instead of failing during TOSA lowering. Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com> Change-Id: I3557c9aa1b77fbd903e5736d32a83f6bff9cd181
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22558
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit e161e05 with merge base 9036d84 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oscarandersson8218
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TOSA section 2.8 limits PRO-FP comparison inputs to fp16 and fp32, with bf16 provided by EXT-BF16.
Allow int8 and int16 inputs legalized by the preceding pass. Reject other unsupported input types during partitioning so they remain on CPU instead of failing during TOSA lowering.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @robell @rascani