[ET-VK][q8ta] Route im2col convolution through unsigned dot - #22564
Merged
Conversation
Pull Request resolved: #22538 PowerVR can lose padding lanes when q8ta im2col writes a local vector through a runtime component index. Construct the vector from four statically addressed loads to avoid the compiler/driver failure. Authored with Codex. ghstack-source-id: 424669153 @exported-using-ghexport Differential Revision: [D118585511](https://our.internmc.facebook.com/intern/diff/D118585511/)
Pull Request resolved: #22539 Use unsigned accumulating-saturating packed dot when Vulkan accelerates unsigned packed dot but not signed packed dot. Keep weight prepack and execution routing consistent while preserving signed routing elsewhere. Authored with Codex. ghstack-source-id: 424669155 @exported-using-ghexport Differential Revision: [D118585646](https://our.internmc.facebook.com/intern/diff/D118585646/)
Pull Request resolved: #22540 Use corrected unsigned accumulating-saturating packed dot for im2col convolution when the adapter accelerates unsigned but not signed packed dot and the accumulator bound is safe. Support both texture- and buffer-backed packed weights. Preserve signed routing elsewhere. Authored with Codex. ghstack-source-id: 424669159 @exported-using-ghexport Differential Revision: [D118585647](https://our.internmc.facebook.com/intern/diff/D118585647/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22564
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 145 PendingAs of commit 89f88c8 with merge base 02ee1ca ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
SS-JIA
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #22540 by @SS-JIA
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/637/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/637/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/636/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/637/orig
Differential Revision: D118585647
@diff-train-skip-merge