[ET-VK][Ez] Allow ParamsBindList to append a single Binding Info
#4593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context
This diff adds some API functions to `ParamsBindList` to make it easier to use, specifically
1. Added default constructor
2. Added overload for `append` that takes only one `BufferBindInfo`
The reason for these changes is to make the following pattern easier:
```
ParamsBindList ubo;
if (kernel1) {
ubo.append(ubo1);
}
else {
ubo.append(ubo2);
}
```
This pattern was not possible before because `ubo` could not be default constructed, and `ubo1` and `ubo2` had to be wrapped in an initializer list before being passed to `append`.
Differential Revision: [D60930997](https://our.internmc.facebook.com/intern/diff/D60930997/)
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4593
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1e3acf1 with merge base 192d463 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60930997 |
This was referenced Aug 8, 2024
junpi3
approved these changes
Aug 8, 2024
…ing Info"
## Context
This diff adds some API functions to `ParamsBindList` to make it easier to use, specifically
1. Added default constructor
2. Added overload for `append` that takes only one `BufferBindInfo`
The reason for these changes is to make the following pattern easier:
```
ParamsBindList ubo;
if (kernel1) {
ubo.append(ubo1);
}
else {
ubo.append(ubo2);
}
```
This pattern was not possible before because `ubo` could not be default constructed, and `ubo1` and `ubo2` had to be wrapped in an initializer list before being passed to `append`.
Differential Revision: [D60930997](https://our.internmc.facebook.com/intern/diff/D60930997/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60930997 |
…ing Info"
## Context
This diff adds some API functions to `ParamsBindList` to make it easier to use, specifically
1. Added default constructor
2. Added overload for `append` that takes only one `BufferBindInfo`
The reason for these changes is to make the following pattern easier:
```
ParamsBindList ubo;
if (kernel1) {
ubo.append(ubo1);
}
else {
ubo.append(ubo2);
}
```
This pattern was not possible before because `ubo` could not be default constructed, and `ubo1` and `ubo2` had to be wrapped in an initializer list before being passed to `append`.
Differential Revision: [D60930997](https://our.internmc.facebook.com/intern/diff/D60930997/)
[ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D60930997 |
This was referenced Aug 9, 2024
kirklandsign
added a commit
that referenced
this pull request
Aug 9, 2024
## Context
This diff adds some API functions to `ParamsBindList` to make it easier to use, specifically
1. Added default constructor
2. Added overload for `append` that takes only one `BufferBindInfo`
The reason for these changes is to make the following pattern easier:
```
ParamsBindList ubo;
if (kernel1) {
ubo.append(ubo1);
}
else {
ubo.append(ubo2);
}
```
This pattern was not possible before because `ubo` could not be default constructed, and `ubo1` and `ubo2` had to be wrapped in an initializer list before being passed to `append`.
Differential Revision: D60930997
Pull Request resolved: #4593
---------
Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ParamsBindListto append a single Binding Info #4593Context
This diff adds some API functions to
ParamsBindListto make it easier to use, specificallyappendthat takes only oneBufferBindInfoThe reason for these changes is to make the following pattern easier:
This pattern was not possible before because
ubocould not be default constructed, andubo1andubo2had to be wrapped in an initializer list before being passed toappend.Differential Revision: D60930997