Skip to content

[ET-VK][Ez] Allow ParamsBindList to append a single Binding Info #4593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facebook-github-bot merged 3 commits into from
Aug 9, 2024
Merged

[ET-VK][Ez] Allow ParamsBindList to append a single Binding Info #4593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dde1ba1
[ET-VK][Ez] Allow `ParamsBindList` to append a single Binding Info
SS-JIA Aug 8, 2024
8c98e2d
Update on "[ET-VK][Ez] Allow `ParamsBindList` to append a single Bind…
SS-JIA Aug 8, 2024
1e3acf1
Update on "[ET-VK][Ez] Allow `ParamsBindList` to append a single Bind…
SS-JIA Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backends/vulkan/runtime/vk_api/Descriptor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ ParamsBindList::ParamsBindList(
std::copy(init_list.begin(), init_list.end(), bind_infos.begin());
}

void ParamsBindList::append(const BufferBindInfo& bind_info) {
bind_infos.emplace_back(bind_info);
}

void ParamsBindList::append(const ParamsBindList& other) {
bind_infos.insert(
bind_infos.end(), other.bind_infos.begin(), other.bind_infos.end());
Expand Down
2 changes: 2 additions & 0 deletions backends/vulkan/runtime/vk_api/Descriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,10 @@ struct BufferBindInfo final {
struct ParamsBindList final {
std::vector<BufferBindInfo> bind_infos;

ParamsBindList() = default;
ParamsBindList(std::initializer_list<const BufferBindInfo> init_list);

void append(const BufferBindInfo& bind_info);
void append(const ParamsBindList& other);
};

Expand Down