[llama] Fix text prefiller #4660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In sequential prefill, we should print out the prompt, and we shouldn't print the first token(`<s>`) as well as the token generated by prefill. The runner should have control on what to do with the token generated by prefill. Will add some unit tests later but now it fixes test-llama-runner-mac CI job.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/4660
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f6bbe43 with merge base 7f34796 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Aug 10, 2024
Contributor
|
@larryliu0820 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sequential prefill, we should print out the prompt, and we shouldn't print the first token(
<s>) as well as the token generated by prefill. The runner should have control on what to do with the token generated by prefill.Will add some unit tests later but now it fixes test-llama-runner-mac CI job.