Skip to content

[llama] Fix text prefiller #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
facebook-github-bot merged 2 commits into from
Aug 11, 2024
Merged

[llama] Fix text prefiller #4660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db93e9b
[llama] Fix text prefiller
larryliu0820 Aug 10, 2024
f6bbe43
Lint
larryliu0820 Aug 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions extension/llm/runner/text_prefiller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,31 @@ Result<uint64_t> TextPrefiller::prefill(

ManagedTensor managed_start_pos(&pos_data, {1}, ScalarType::Long);

// run the first token and get back logits tensor. Assuming the first token
// is bos so don't callback.
exec_aten::Tensor logits_tensor = ET_UNWRAP(
text_decoder_runner_->step(managed_tokens, managed_start_pos));
pos = 1; // start from index 1

while (pos < num_prompt_tokens) {
// Run the model
pos_data = start_pos + pos;

Result<exec_aten::Tensor> logits_res =
text_decoder_runner_->step(managed_tokens, managed_start_pos);

ET_CHECK_OK_OR_RETURN_ERROR(logits_res.error());
prev_token = cur_token;

pos++;
// NOLINTNEXTLINE(facebook-hte-ParameterUncheckedArrayBounds)
cur_token = prompt_tokens[pos];

cur_token = pos == num_prompt_tokens
? text_decoder_runner_->logits_to_token(logits_res.get())
: prompt_tokens[pos];
logits_tensor = ET_UNWRAP(
text_decoder_runner_->step(managed_tokens, managed_start_pos));

// print the token as string, decode it with the Tokenizer object
token_callback(ET_UNWRAP(tokenizer_->decode(prev_token, cur_token)));

pos++;
}

cur_token = text_decoder_runner_->logits_to_token(logits_tensor);
}
return cur_token;
}
Expand Down