[ExecuTorch] Unbreak Intel Apple Buck builds #5431
Conversation
The code is gated on `#ifdef __aarch64__`, but the `-march` flag wasn't. Differential Revision: [D62884370](https://our.internmc.facebook.com/intern/diff/D62884370/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5431
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a8fc9bb with merge base 3befc8a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
The code is gated on `#ifdef __aarch64__`, but the `-march` flag wasn't. Differential Revision: [D62884370](https://our.internmc.facebook.com/intern/diff/D62884370/) ghstack-source-id: 243083716 Pull Request resolved: #5431
|
This pull request was exported from Phabricator. Differential Revision: D62884370 |
| fbobjc_platform_compiler_flags = [ | ||
| ( | ||
| ".*arm64.*", | ||
| ["-march=armv8+bf16"], |
There was a problem hiding this comment.
I'm not sure how this fix the issue, maybe some comments can help
There was a problem hiding this comment.
Wouldn't that crash on older phones/laptops?
definitely internal, not sure if fbobjc_-prefixed flags affect OSS. I will follow up by looking into getting these flags set properly on OSS ARM64. |
| fbobjc_platform_compiler_flags = [ | ||
| ( | ||
| ".*arm64.*", | ||
| ["-march=armv8+bf16"], |
There was a problem hiding this comment.
Wouldn't that crash on older phones/laptops?
|
This pull request has been merged in 06c0fa3. |
Stack from ghstack (oldest at bottom):
The code is gated on
#ifdef __aarch64__, but the-marchflag wasn't.Differential Revision: D62884370