Skip to content

[ExecuTorch] Unbreak Intel Apple Buck builds #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[ExecuTorch] Unbreak Intel Apple Buck builds #5431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions kernels/optimized/lib_defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,11 @@ def define_libs():
],
),
],
fbobjc_compiler_flags = [
"-march=armv8+bf16",
fbobjc_platform_compiler_flags = [
(
".*arm64.*",
["-march=armv8+bf16"],
Copy link
Contributor

@cccclai cccclai Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this fix the issue, maybe some comments can help

Copy link
Contributor

@malfet malfet Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that crash on older phones/laptops?

),
],
fbobjc_exported_preprocessor_flags = [
"-DET_BUILD_WITH_BLAS",
Expand Down