Centralize soc_to_chipset map #6033
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6033
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b71dfb0 with merge base a6f754a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64080089 |
haowhsu-quic
approved these changes
Oct 9, 2024
Collaborator
haowhsu-quic
left a comment
haowhsu-quic
left a comment
There was a problem hiding this comment.
That's nice, thank you for helping this.
chiwwang
approved these changes
Oct 9, 2024
kirklandsign
approved these changes
Oct 9, 2024
cccclai
force-pushed
the
export-D64080089
branch
from
df4b90b to
cc6ceaa
Compare
cccclai
added a commit
to cccclai/executorch-1
that referenced
this pull request
Oct 9, 2024
Summary: We have multiple copy of the maps in the codebase and it's error prone. Provide a util function for the map so we can get the map from the same function Reviewed By: kirklandsign Differential Revision: D64080089
Summary: We have multiple copy of the maps in the codebase and it's error prone. Provide a util function for the map so we can get the map from the same function Reviewed By: kirklandsign Differential Revision: D64080089
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64080089 |
cccclai
force-pushed
the
export-D64080089
branch
from
cc6ceaa to
b71dfb0
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64080089 |
Contributor
|
This pull request has been merged in a57853c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We have multiple copy of the maps in the codebase and it's error prone. Provide a util function for the map so we can get the map from the same function
Differential Revision: D64080089