ArmBackend: Add support for Conv1D #6453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oscarandersson8218
commented
Oct 23, 2024
oscarandersson8218
commented
- Add Conv1dUnsqueezePass
- Extend arm-pass-utils
- Add unittests for Conv1D
- Add Conv1dUnsqueezePass - Extend arm-pass-utils - Add unittests for Conv1D Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Ia0734538c20526ca0856d1943c4e0a47af7a22c2
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6453
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 24cc1c8 with merge base 41a57e6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
digantdesai
approved these changes
Oct 25, 2024
| from executorch.exir.pass_base import ExportPass, PassResult | ||
|
|
||
|
|
||
| class Conv1dUnsqueezePass(ExportPass): |
Contributor
There was a problem hiding this comment.
can we use xnnpack's pass here somehow (and keep quant logic separate)? OK with duplication TBH if it means less complexity or cross deps
|
|
||
| # Expeted to fail as Conv1D requires transpoes which isn't supported on u55 | ||
| @parameterized.expand(testsuite_u55) | ||
| @unittest.expectedFailure |
Contributor
There was a problem hiding this comment.
if its a static thing just skip the test?
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Sorry I missed this |
Change-Id: Ie42ec931e5544eb26dfce565dd52c0436eba5319
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: Ib918e209b153488976a4e3204463d185230147c1
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I71f72226a4a51631c2745bdfe46193db4ee937fd
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.