Skip to content

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented Jan 31, 2025

Differential Revision: D68986388

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Differential Revision: D68986388
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8124

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit d13ddfb with merge base dd8da0f (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68986388

if not try_set_param(conv_bias_node, fused_conv_bias) and try_set_param(
bn_bias_node, fused_conv_bias
):
# pyre-ignore[60]
Copy link
Collaborator

@zingo zingo Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? I heard rumors that pyre was disabled on backends/arm when mypy was introduced?
Asking as we where thinking of removed all # pyre stuff soon but maybe we should wait.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirklandsign do you still need this?, It's really no problem at all to merge if it is, we have plenty of pyre-ignore already anyway. :)

@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Feb 3, 2025
@facebook-github-bot facebook-github-bot merged commit cc6d9a5 into pytorch:main Feb 15, 2025
107 of 114 checks passed
@kirklandsign kirklandsign deleted the export-D68986388 branch February 24, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants