-
Notifications
You must be signed in to change notification settings - Fork 712
Fix pyre #8124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pyre #8124
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8124
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit d13ddfb with merge base dd8da0f ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D68986388 |
| if not try_set_param(conv_bias_node, fused_conv_bias) and try_set_param( | ||
| bn_bias_node, fused_conv_bias | ||
| ): | ||
| # pyre-ignore[60] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed? I heard rumors that pyre was disabled on backends/arm when mypy was introduced?
Asking as we where thinking of removed all # pyre stuff soon but maybe we should wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kirklandsign do you still need this?, It's really no problem at all to merge if it is, we have plenty of pyre-ignore already anyway. :)
Differential Revision: D68986388
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218