Skip to content

Fix pyre #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix pyre #8124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/arm/_passes/fuse_batchnorm2d_pass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def try_set_param(
if not try_set_param(conv_bias_node, fused_conv_bias) and try_set_param(
bn_bias_node, fused_conv_bias
):
# pyre-ignore[60]
Copy link
Collaborator

@zingo zingo Feb 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? I heard rumors that pyre was disabled on backends/arm when mypy was introduced?
Asking as we where thinking of removed all # pyre stuff soon but maybe we should wait.

Copy link
Contributor

@digantdesai digantdesai Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@zingo zingo Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kirklandsign do you still need this?, It's really no problem at all to merge if it is, we have plenty of pyre-ignore already anyway. :)

# Conv didn't have bias but batchnorm did, steal bias from batchnorm.
conv_args = (*conv.args[0:2], bn_bias_node, *conv.args[3:])
conv.args = conv_args
Expand Down
Loading