Buck changes for ObjC/Swift bindings. #8825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from shoumikhin:export-D70377502

Feb 28, 2025

Contributor

shoumikhin commented Feb 28, 2025

Summary: Add resources for the tests.

Differential Revision: D70377502

pytorch-bot bot commented Feb 28, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8825

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit 5174ffe with merge base 781b082 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Feb 28, 2025

This pull request was exported from Phabricator. Differential Revision: D70377502

facebook-github-bot added the fb-exported label

Contributor Author

shoumikhin commented Feb 28, 2025

@pytorchbot label "topic: not user facing"

pytorch-bot bot added the topic: not user facing label

Contributor

facebook-github-bot commented Feb 28, 2025

This pull request was exported from Phabricator. Differential Revision: D70377502

mergennachin approved these changes

View reviewed changes

shoumikhin mentioned this pull request

Lay out ObjC/Swift bindings skeleton #8826

Merged

Contributor

facebook-github-bot commented Feb 28, 2025

This pull request was exported from Phabricator. Differential Revision: D70377502

Contributor

kirklandsign commented Feb 28, 2025

From my understanding, we want to export a model every time we run the test, unless we are doing BC/FC check.

Contributor Author

shoumikhin commented Feb 28, 2025

@kirklandsign ptal at https://github.com/pytorch/executorch/tree/main/extension/module/test/resources, we kinda replicate the same setup here

Contributor

facebook-github-bot commented Feb 28, 2025

This pull request was exported from Phabricator. Differential Revision: D70377502


          Buck changes for ObjC/Swift bindings. (#8825)

5174ffe

Summary:
Pull Request resolved: #8825

Add resources for the tests.

Reviewed By: mergennachin

Differential Revision: D70377502

Contributor

facebook-github-bot commented Feb 28, 2025

This pull request was exported from Phabricator. Differential Revision: D70377502

facebook-github-bot merged commit a5f9210 into pytorch:main

56 of 57 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing