-
Notifications
You must be signed in to change notification settings - Fork 712
Lay out ObjC/Swift bindings skeleton #8826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8826
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
|
@mergennachin thanks for suggestions! |
@shoumikhin Yeap, I understand that the APIs can be immediately part of the OSS nightly builds, which is great. And you are building the scaffolding so that @bsoyluoglu fill in directly the implementations. I am just making sure that if the users start immediately using the APIs in the nightly, they can expect a certain level of changes, including breaking changes in the API until ET v0.7 release. Otherwise, if you don't mark as experimental, it will be harder to make API breaking changes after 0.6 release (March/April), because by default it will be considered a stable API. On top of the files, you can just mark them as experimental in the docblock. |
|
@mergennachin those must be experimental for sure, until we switch internal clients to use them and prove everything works well. I've already marked them as such per your suggestion. |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Landing changes for this RFC
#8360