Skip to content

Conversation

@shoumikhin
Copy link
Contributor

@shoumikhin shoumikhin commented Feb 28, 2025

Landing changes for this RFC
#8360

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8826

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@shoumikhin
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mergennachin mergennachin added release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) and removed topic: not user facing labels Feb 28, 2025
@mergennachin
Copy link
Contributor

  1. Added "release notes: api" label instead of "topic: not user facing" since it looks like user facing API change.

  2. While we're still finalizing the API, do you wanna tag them as "experimental" as per the lifecycle? https://pytorch.org/executorch/main/api-life-cycle.html#how-to-mark-api-state In 0.6, we make the swift/objC bindings as experimental, and in 0.7 we can promote to stable APIs.. That way, you have more flexibility in terms of changing APIs until 0.7 without breaking our API policy.

@mergennachin mergennachin self-requested a review February 28, 2025 15:40
@shoumikhin
Copy link
Contributor Author

@mergennachin thanks for suggestions!
This PR (likewise #8825 and a bunch landed yesterday) basically creates a frame for @bsoyluoglu to fill with some gems. So that the actual implementation can immediately become a part of OSS nightly builds, as well as available internally via Buck.

@mergennachin
Copy link
Contributor

mergennachin commented Feb 28, 2025

This PR (likewise #8825 and a bunch landed yesterday) basically creates a frame for @bsoyluoglu to fill with some gems. So that the actual implementation can immediately become a part of OSS nightly builds, as well as available internally via Buck.

@shoumikhin Yeap, I understand that the APIs can be immediately part of the OSS nightly builds, which is great. And you are building the scaffolding so that @bsoyluoglu fill in directly the implementations.

I am just making sure that if the users start immediately using the APIs in the nightly, they can expect a certain level of changes, including breaking changes in the API until ET v0.7 release. Otherwise, if you don't mark as experimental, it will be harder to make API breaking changes after 0.6 release (March/April), because by default it will be considered a stable API.

On top of the files, you can just mark them as experimental in the docblock.

@shoumikhin
Copy link
Contributor Author

@mergennachin those must be experimental for sure, until we switch internal clients to use them and prove everything works well. I've already marked them as such per your suggestion.

@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@shoumikhin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@shoumikhin shoumikhin merged commit eef7b44 into pytorch:main Feb 28, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants