Replace typing module hints with modern syntax in handlers core utils#3596
Open
Manimaran-tech wants to merge 5 commits intopytorch:masterfrom
Open
Replace typing module hints with modern syntax in handlers core utils#3596Manimaran-tech wants to merge 5 commits intopytorch:masterfrom
Manimaran-tech wants to merge 5 commits intopytorch:masterfrom
Conversation
added 4 commits
February 26, 2026 19:53
Fixes pytorch#3481 - Optional[int] -> int | None - Remove unused typing import
Fixes pytorch#3481 - Optional[Events] -> Events | None - Remove Optional from typing import
Fixes pytorch#3481 - Optional[Events] -> Events | None - Move Callable to collections.abc
Fixes pytorch#3481 - Move Callable to collections.abc - Remove unused Optional import
Contributor
Author
|
@aaishwarymishra i have created 11 pr as you told , i also checked the build issue in the other pr's they are related to Netlify i think it should be approved to continue ig |
auto-merge was automatically disabled
February 26, 2026 15:40
Head branch was pushed to by a user without write access
Manimaran-tech
force-pushed
the
fix/typing-handlers-core-utils
branch
from
7e5e6e7 to
2de9201
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modernize type hints in
ignite/handlerscore utility files by replacingtypingmodule imports (e.g.,Optional,Union,Callable,Sequence) with Python 3.10+ built-in syntax (X | None,list[...],collections.abc).Files changed:
ignite/handlers/__init__.pyignite/handlers/utils.pyignite/handlers/time_limit.pyignite/handlers/timing.pyRelated to replace typing hints in ignite/handlers/tqdm_logger.py #3591