replace typing hints in ignite/handlers/tqdm_logger.py#3591
Open
roli-lpci wants to merge 4 commits intopytorch:masterfrom
Open
replace typing hints in ignite/handlers/tqdm_logger.py#3591roli-lpci wants to merge 4 commits intopytorch:masterfrom
roli-lpci wants to merge 4 commits intopytorch:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vfdev-5
reviewed
Feb 25, 2026
omkar-334
previously requested changes
Feb 25, 2026
ignite requires Python >=3.10, so `X | Y` union syntax works natively without the future import. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Thanks for the review! Removed the unnecessary |
vfdev-5
reviewed
Feb 25, 2026
ignite/handlers/tqdm_logger.py
Outdated
| """TQDM logger.""" | ||
| from collections import OrderedDict | ||
| from typing import Any, Callable, List, Optional, Union | ||
| from typing import Any, Callable |
Collaborator
There was a problem hiding this comment.
I see in different PRs we have either from collections.abc import Callable, Mapping or from typing import Callable, Mapping. Let's make the code consistent and use from collections.abc import Callable, Mapping.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 26, 2026
Open
Open
vfdev-5
dismissed
omkar-334’s stale review
Contributor addressed requested changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3481
Description: Replace old typing hints with Python 3.10+ syntax in
ignite/handlers/tqdm_logger.py.Union[A, B]->A | BOptional[A]->A | NoneList->listfrom __future__ import annotationsList,Optional,Union)Check list: