Replace typing module hints with modern syntax in handlers loggers (polyaxon, visdom, wandb)#3598
Open
Manimaran-tech wants to merge 7 commits intopytorch:masterfrom
Open
Conversation
vfdev-5
reviewed
Feb 26, 2026
ignite/handlers/polyaxon_logger.py
Outdated
| output_transform: Optional[Callable] = None, | ||
| global_step_transform: Optional[Callable[[Engine, Union[str, Events]], int]] = None, | ||
| state_attributes: Optional[List[str]] = None, | ||
| metric_names: Optional[list[str] | str] = None, |
Collaborator
There was a problem hiding this comment.
Same here as in a previous PR: replace Optional[A] -> A | None
Manimaran-tech
force-pushed
the
fix/typing-handlers-loggers-part2
branch
from
c214a37 to
df1fe69
Compare
vfdev-5
requested changes
Feb 26, 2026
ignite/handlers/visdom_logger.py
Outdated
| metric_names: Optional[Union[List[str], str]] = None, | ||
| output_transform: Optional[Callable] = None, | ||
| global_step_transform: Optional[Callable[[Engine, Union[str, Events]], int]] = None, | ||
| metric_names: Optional[list[str] | str] = None, |
Collaborator
There was a problem hiding this comment.
here, Optional is not replaced and below
Contributor
Author
There was a problem hiding this comment.
let me check it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modernize type hints in
ignite/handlerslogger files (Part 2) by replacingtypingmodule imports with Python 3.10+ built-in syntax.Files changed:
ignite/handlers/polyaxon_logger.pyignite/handlers/visdom_logger.pyignite/handlers/wandb_logger.pyRelated to #3591