Skipping tcp tests, fixing ci#3775
Merged
Merged
Conversation
vfdev-5
reviewed
Jun 3, 2026
vfdev-5
reviewed
Jun 3, 2026
Collaborator
Author
|
@vfdev-5 done. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate CI hangs related to legacy tcp://-based distributed initialization by removing tcp:// coverage from the test matrix, switching tests/fixtures to env://, and adding explicit runtime guards that reject tcp:// init methods with a migration message.
Changes:
- Removed
tcp://...from several distributed test parametrizations to stop exercising the legacy path that can hang. - Updated distributed test fixtures to use
env://and setMASTER_ADDR/MASTER_PORTexplicitly. - Added explicit
ValueErrorguards rejectinginit_method="tcp://..."inidist.Paralleland the native computation model, plus new tests asserting the error.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
tests/ignite/distributed/utils/test_native.py |
Removes tcp:// init_method from distributed test parametrization. |
tests/ignite/distributed/test_launcher.py |
Drops tcp:// param case and adds a test asserting tcp:// now errors. |
tests/ignite/distributed/comp_models/test_native.py |
Replaces tcp:// init with TCPStore usage in context tests; removes tcp:// parametrization; adds a new error test. |
tests/ignite/conftest.py |
Switches single-node distributed fixtures from tcp:// to env:// and sets MASTER_ADDR/MASTER_PORT. |
ignite/distributed/launcher.py |
Removes tcp:// example and raises ValueError if init_method starts with tcp://. |
ignite/distributed/comp_models/native.py |
Raises ValueError if init_method starts with tcp:// in native backend creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
233
to
236
| free_port = _setup_free_port(local_rank) | ||
| os.environ["MASTER_ADDR"] = "localhost" | ||
| os.environ["MASTER_PORT"] = str(free_port) | ||
|
|
Comment on lines
485
to
490
| temp_file = None | ||
| free_port = _setup_free_port(local_rank) | ||
| init_method = f"tcp://localhost:{free_port}" | ||
| init_method = "env://" | ||
| os.environ["MASTER_ADDR"] = "localhost" | ||
| os.environ["MASTER_PORT"] = str(free_port) | ||
|
|
Comment on lines
+337
to
+338
| store = dist.TCPStore("0.0.0.0", 2222, world_size=1, is_master=True) | ||
| dist.init_process_group(true_backend, store=store, world_size=1, rank=0) |
Comment on lines
+362
to
+364
| is_master = rank == 0 | ||
| store = dist.TCPStore("0.0.0.0", 2222, world_size=world_size, is_master=is_master) | ||
| dist.init_process_group(true_backend, store=store, world_size=world_size, rank=rank) |
Comment on lines
+450
to
+452
| is_master = local_rank == 0 | ||
| store = dist.TCPStore("0.0.0.0", 2222, world_size=world_size, is_master=is_master) | ||
| dist.init_process_group("nccl", store=store, world_size=world_size, rank=local_rank) |
Comment on lines
259
to
+263
| free_port = _setup_free_port(local_rank) | ||
| init_method = f"tcp://localhost:{free_port}" | ||
| init_method = "env://" | ||
| temp_file = None | ||
| os.environ["MASTER_ADDR"] = "localhost" | ||
| os.environ["MASTER_PORT"] = str(free_port) |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves the CI hangs and provides a clear guide to users on how to migrate away from the legacy
tcp://initialization methodCheck list: