Skip to content

DOC: improve README logo in dark mode#3780

Merged
vfdev-5 merged 1 commit into
pytorch:masterfrom
importstring:doc/ignite-logo-dark-mode
Jun 8, 2026
Merged

DOC: improve README logo in dark mode#3780
vfdev-5 merged 1 commit into
pytorch:masterfrom
importstring:doc/ignite-logo-dark-mode

Conversation

@importstring

Copy link
Copy Markdown
Contributor

This PR improves logo rendering across light and dark themes by switching the displayed asset based on the viewer's color scheme.

Proposed README snippet:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/pytorch/ignite/master/assets/logo/ignite_logo_mixed_light.svg">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/pytorch/ignite/master/assets/logo/ignite_logo_mixed.svg">
  <img src="https://raw.githubusercontent.com/pytorch/ignite/master/assets/logo/ignite_logo_mixed.svg"
       alt="PyTorch-Ignite logo"
       width="512">
</picture>

Preview of the current and updated rendering:

Current logo rendering Updated logo in light mode Updated logo in dark mode

The first image is the proposed change, and the third is what the logo currently looks like.

@importstring

Copy link
Copy Markdown
Contributor Author

This follows the same pattern used by other ML projects. For example, Hugging Face’s README uses a light/dark aware logo where the wordmark color changes with the theme so that it stays readable in both modes. The change here mirrors that behaviour for the PyTorch-Ignite logo.

Hugging Face README in light mode Hugging Face README in dark mode

@importstring importstring changed the title doc/ignite-logo-dark-mode DOC: improve README logo in dark mode Jun 8, 2026

@vfdev-5 vfdev-5 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving that, @importstring !

@vfdev-5
vfdev-5 merged commit 78ebbd2 into pytorch:master Jun 8, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants