Skip to content

adjust header inclusions in C10 as sugguested by IWYU#102467

Closed
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:c10_iwyu2
Closed

adjust header inclusions in C10 as sugguested by IWYU#102467
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:c10_iwyu2

Conversation

@cyyever
Copy link
Copy Markdown
Collaborator

@cyyever cyyever commented May 29, 2023

This PR aims to reduce unused header inclusions in C10.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/102467

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9700734:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 29, 2023

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label May 29, 2023
@cyyever cyyever force-pushed the c10_iwyu2 branch 2 times, most recently from 85edb2a to e0b6e1d Compare May 29, 2023 05:37
@Skylion007 Skylion007 requested a review from malfet May 29, 2023 18:31
@Skylion007 Skylion007 added the ciflow/binaries Trigger all binary build and upload jobs on the PR label May 29, 2023
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 30, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 30, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 30, 2023

Successfully rebased c10_iwyu2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout c10_iwyu2 && git pull --rebase)

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 30, 2023

@pytorchbot rebase viable/strict

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 30, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: viable/strict

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 30, 2023

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 30, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 30, 2023

Tried to rebase and push PR #102467, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 31, 2023

@pytorchbot rebase -b viable/strict

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 31, 2023

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 31, 2023

Successfully rebased c10_iwyu2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout c10_iwyu2 && git pull --rebase)

albanD
albanD approved these changes May 31, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 31, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 31, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 31, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

shaoyf42 pushed a commit to shaoyf42/pytorch that referenced this pull request Jun 1, 2023
@cyyever @shaoyf42
adjust header inclusions in C10 as sugguested by IWYU (pytorch#102467)
1fab3d3 
This PR aims to reduce unused header inclusions in C10.

Pull Request resolved: pytorch#102467
Approved by: https://github.com/albanD
@cyyever cyyever deleted the c10_iwyu2 branch June 3, 2023 04:01
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 25, 2026
@cyyever @pytorchmergebot
adjust header inclusions in C10 as sugguested by IWYU (pytorch#102467)
8038b3b 
This PR aims to reduce unused header inclusions in C10.

Pull Request resolved: pytorch#102467
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @albanD @Skylion007 @pytorchbot