Remove cpp_custom_type_hack

[peterbell10]

Stack from ghstack (oldest at bottom):

• -> Remove cpp_custom_type_hack #104569
• Remove remaining deprecated fbgemm operators #118526
• record_function: remove legacy internal operators #72303
• [RELAND] Remove deprecated fbgemm operators #112153

Closes #72263

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104569

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 0eab6f6 with merge base f9971da ():

NEW FAILURES - The following jobs have failed:

• pull / linux-focal-py3-clang9-android-ndk-r21e-gradle-custom-build-single / build-and-test (default, 1, 1, linux.2xlarge) (gh)
  Process completed with exit code 1.
• pull / linux-jammy-py3.8-gcc11-mobile-lightweight-dispatch-build / build (gh)
  Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[peterbell10]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[pytorchmergebot]

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/peterbell10/580/orig returned non-zero exit code 1

Rebasing (1/3)
Auto-merging aten/src/ATen/native/RNN.cpp
Auto-merging aten/src/ATen/native/native_functions.yaml
CONFLICT (content): Merge conflict in aten/src/ATen/native/native_functions.yaml
Auto-merging build_variables.bzl
Auto-merging caffe2/CMakeLists.txt
Auto-merging test/forward_backward_compatibility/check_forward_backward_compatibility.py
CONFLICT (content): Merge conflict in test/forward_backward_compatibility/check_forward_backward_compatibility.py
Auto-merging test/quantization/core/test_quantized_op.py
Auto-merging test/test_nn.py
Auto-merging torch/overrides.py
error: could not apply 77c40fea814... Remove deprecated fbgemm operators
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 77c40fea814... Remove deprecated fbgemm operators

Raised by https://github.com/pytorch/pytorch/actions/runs/6538376565

[github-actions]

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

[lezcano]

@albanD so what's the state of this?

[albanD]

I think there are a couple things:

• All the PRs below require quite a bit of fixing for internal code that relies on them
• It is unclear what's the way to go without this if you need to pipe a class through the dispatcher today (cc @zou3519 )
• It is unclear what's the gain of removing all of these (like what's the ROI for all this work?)

[kimishpatel]

It is unclear what's the gain of removing all of these (like what's the ROI for all this work?)

Yeah it will be good to highlight this

[peterbell10]

It is unclear what's the way to go without this if you need to pipe a class through the dispatcher today

I don't understand what's wrong with torchbind custom classes?

Anyway, @albanD if you don't think it's worth doing then we can just abandon this. After all, it was you that asked me to clean it up in the first place.

[albanD]

I don't understand what's wrong with torchbind custom classes?

I will let @zou3519 answer on this one. My understanding is that it doesn't work with a bunch of things.

Anyway, albanD if you don't think it's worth doing then we can just abandon this. After all, it was you that asked me to clean it up in the first place.

Yes I think it might be best to abandon this one :( Sorry for the back and forth, I didn't expect it was used that much.

[zou3519]

torchbind doesn't work with PT2 yet (we're working on it). But we're also not telling people to use cpp_custom_type_hack as a workaround.