Skip to content

Remove deprecated fbgemm operators #104535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Remove deprecated fbgemm operators #104535

wants to merge 6 commits into from

Conversation

@peterbell10
Copy link
Collaborator

@peterbell10 peterbell10 commented Jul 3, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

These operators are not used and have been deprecated since #72690 (Feb 2022). Additionally, the torch.jit.quantized interface has been deprecated since #40102 (June 2020).

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Jul 3, 2023
@peterbell10 peterbell10 mentioned this pull request Jul 3, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/104535

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a1018d3 with merge base 0d368f5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@peterbell10
Remove deprecated fbgemm operators and cpp_custom_type_hack
a477dce 
Closes #72263

These operators are not used and have been deprecated since #72690
(Feb 2022).

[ghstack-poisoned]
peterbell10 added a commit that referenced this pull request Jul 3, 2023
@peterbell10
Remove deprecated fbgemm operators and cpp_custom_type_hack
0c5d922 
Closes #72263

These operators are not used and have been deprecated since #72690
(Feb 2022).

ghstack-source-id: 34f460f
Pull Request resolved: #104535
@peterbell10 peterbell10 marked this pull request as draft July 3, 2023 20:09
@peterbell10 peterbell10 mentioned this pull request Jul 4, 2023
Closed
@peterbell10
Update on "Remove deprecated fbgemm operators and cpp_custom_type_hack"
b3cfaa6 
Closes #72263

These operators are not used and have been deprecated since #72690
(Feb 2022).

[ghstack-poisoned]
@peterbell10
Update on "Remove deprecated fbgemm operators and cpp_custom_type_hack"
1be933b 
These operators are not used and have been deprecated since #72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since #40102 (June 2020).

[ghstack-poisoned]
@peterbell10 peterbell10 changed the title Remove deprecated fbgemm operators and cpp_custom_type_hack Remove deprecated fbgemm operators Aug 8, 2023
peterbell10 added a commit to peterbell10/pytorch that referenced this pull request Aug 8, 2023
@peterbell10
Remove deprecated fbgemm operators
1da2cba 
These operators are not used and have been deprecated since pytorch#72690
(Feb 2022).

ghstack-source-id: 8d92bed
Pull Request resolved: pytorch#104535
@peterbell10
Update on "Remove deprecated fbgemm operators"
a25b44a 
These operators are not used and have been deprecated since #72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since #40102 (June 2020).

[ghstack-poisoned]
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Oct 7, 2023
@peterbell10
Rebase on "Remove deprecated fbgemm operators"
8d7c65c 
These operators are not used and have been deprecated since #72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since #40102 (June 2020).

[ghstack-poisoned]
@peterbell10 peterbell10 added topic: bc breaking topic category and removed Stale labels Oct 16, 2023
@peterbell10
Update on "Remove deprecated fbgemm operators"
a1018d3 
These operators are not used and have been deprecated since #72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since #40102 (June 2020).

[ghstack-poisoned]
@peterbell10 peterbell10 marked this pull request as ready for review October 18, 2023 14:08
@peterbell10 peterbell10 requested a review from ezyang October 21, 2023 09:31
@ezyang
Copy link
Contributor

ezyang commented Oct 22, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 22, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Oct 23, 2023
@peterbell10 @pytorchmergebot
record_function: remove legacy internal operators (#72303)
0be84bb 
These operators have not been used since #76420 but were preserved for TorchScript backward compatibility

Pull Request resolved: #72303
Approved by: https://github.com/albanD
ghstack dependencies: #104535
@facebook-github-bot facebook-github-bot deleted the gh/peterbell10/579/head branch October 25, 2023 14:25
@facebook-github-bot
Copy link
Contributor

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

This Pull Request has been reverted by a revert inside Meta. To re-land this change, please open another pull request, assign the same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@peterbell10 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 25, 2023
@pytorchmergebot
Revert "Remove deprecated fbgemm operators (#104535)"
5ce8002 
This reverts commit 57c7aa1.

Reverted #104535 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](#104535 (comment)))
@peterbell10
Copy link
Collaborator Author

@kit1980 would you be able to share any details of the meta-internal failures? I guess some of the deprecated APIs are still being used, but maybe at least some are safe to remove?

@peterbell10
Copy link
Collaborator Author

Had to reopened this as #112153 because the branch was deleted by the facebook bot.

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@peterbell10 @xuhancn
Remove deprecated fbgemm operators (pytorch#104535)
905104e 
These operators are not used and have been deprecated since pytorch#72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since pytorch#40102 (June 2020).
Pull Request resolved: pytorch#104535
Approved by: https://github.com/ezyang
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@peterbell10 @xuhancn
record_function: remove legacy internal operators (pytorch#72303)
fabf4d2 
These operators have not been used since pytorch#76420 but were preserved for TorchScript backward compatibility

Pull Request resolved: pytorch#72303
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#104535
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@pytorchmergebot @xuhancn
Revert "Remove deprecated fbgemm operators (pytorch#104535)"
4b2dd6c 
This reverts commit 57c7aa1.

Reverted pytorch#104535 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#104535 (comment)))
@kit1980 kit1980 mentioned this pull request Nov 8, 2023
Closed
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@peterbell10 @Skylion007
Remove deprecated fbgemm operators (pytorch#104535)
78e082d 
These operators are not used and have been deprecated since pytorch#72690 (Feb 2022). Additionally, the `torch.jit.quantized` interface has been deprecated since pytorch#40102 (June 2020).
Pull Request resolved: pytorch#104535
Approved by: https://github.com/ezyang
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@peterbell10 @Skylion007
record_function: remove legacy internal operators (pytorch#72303)
bd331fb 
These operators have not been used since pytorch#76420 but were preserved for TorchScript backward compatibility

Pull Request resolved: pytorch#72303
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#104535
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@pytorchmergebot @Skylion007
Revert "Remove deprecated fbgemm operators (pytorch#104535)"
6ecf0e5 
This reverts commit 57c7aa1.

Reverted pytorch#104535 on behalf of https://github.com/facebook-github-bot due to Diff reverted internally ([comment](pytorch#104535 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: quantization release notes category Reverted topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterbell10 @ezyang @pytorchmergebot @facebook-github-bot @pytorchbot