record_function: remove legacy internal operators #72303
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
|
🔗 Helpful links
❌ 1 New FailuresAs of commit a127895 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
…emove legacy internal operators" [ghstack-poisoned]
[ghstack-poisoned]
…l operators" [ghstack-poisoned]
|
@peterbell10 your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Oct 24, 2023
This reverts commit 0be84bb. Reverted #72303 on behalf of https://github.com/izaitsevfb due to Apparently _record_function_enter is still used internally at Meta in several places and in lots of internal tests. ([comment](#72303 (comment)))
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
These operators have not been used since pytorch#76420 but were preserved for TorchScript backward compatibility Pull Request resolved: pytorch#72303 Approved by: https://github.com/albanD ghstack dependencies: pytorch#104535
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
)" This reverts commit 0be84bb. Reverted pytorch#72303 on behalf of https://github.com/izaitsevfb due to Apparently _record_function_enter is still used internally at Meta in several places and in lots of internal tests. ([comment](pytorch#72303 (comment)))
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
These operators have not been used since pytorch#76420 but were preserved for TorchScript backward compatibility Pull Request resolved: pytorch#72303 Approved by: https://github.com/albanD ghstack dependencies: pytorch#104535
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
)" This reverts commit 0be84bb. Reverted pytorch#72303 on behalf of https://github.com/izaitsevfb due to Apparently _record_function_enter is still used internally at Meta in several places and in lots of internal tests. ([comment](pytorch#72303 (comment)))
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
These operators have not been used since #76420 but were preserved for TorchScript backward compatibility [ghstack-poisoned]
github-actions
bot
added
the
oncall: distributed
These operators have not been used since #76420 but were preserved for TorchScript backward compatibility cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 [ghstack-poisoned]
[ghstack-poisoned]
…internal operators" [ghstack-poisoned]
These operators are not used in eager since #76420, and are only retained for TorchScript BC which has now expired. BC-breaking message: TorchScript exported models that use `torch.autograd.profiler.record_function` and were exported on PyTorch < `2.0` will no longer be loadable. Please re-export your model with 2.0 or newer. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
These operators are not used in eager since #76420, and are only retained for TorchScript BC which has now expired.
BC-breaking message:
TorchScript exported models that use
torch.autograd.profiler.record_functionand were exported on PyTorch <2.0will no longer be loadable. Please re-export your model with 2.0 or newer.