[codemod] Remove unused variables in caffe2/caffe2/operators/softmax_op_cudnn.cc #121995
Conversation
…op_cudnn.cc Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Test Plan: Sandcastle Reviewed By: palmje Differential Revision: D54931224
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121995
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 40cb525 with merge base dfc5e93 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D54931224 |
|
@pytorchbot merge |
r-barnes
added
release notes: cpp
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot -r merge |
|
❌ 🤖 pytorchbot command failed: Try |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "Simple fix" |
1 similar comment
|
@pytorchbot merge -f "Simple fix" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…op_cudnn.cc (#121995) Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Test Plan: Sandcastle Reviewed By: palmje Differential Revision: D54931224 Pull Request resolved: #121995 Approved by: https://github.com/Skylion007
4 participants
Summary:
LLVM-15 has a warning
-Wunused-but-set-variablewhich we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with
[[maybe_unused]], mostly in cases where the variable is used, but, eg, in anassertstatement that isn't present in production code.Test Plan: Sandcastle
Reviewed By: palmje
Differential Revision: D54931224
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang