-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Symmetric memory] set handle type for ROCm #161741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161741
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e05819a with merge base 82f63c8 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@yuankaichen-amd my PR couldn't possibly have caused those rocm failures, I'll leave it to you to figure it out and land the PR |
Hi Natalia, Please rebase your branch to head and try again. For the two failures, they are irrelevant to this PR:
|
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
5f0b628
to
e05819a
Compare
Please note that ciflow/rocm (mi200s) are having infra issues and the signal will take a long time. But for this PR this test is only run on the mi300 anyway, so you can force-merge once you get a good mi300 signal. |
@yuankaichen-amd I see the CI is still failing for reasons unrelated to my PR. Feel free to take this PR over and do with it what you want. |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
@pytorchbot merge -f "unrelated rocm failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Unblocking #161741 Pull Request resolved: #162035 Approved by: https://github.com/Skylion007, https://github.com/ngimel
Thank you all! |
Fixes pytorch#161722 Pull Request resolved: pytorch#161741 Approved by: https://github.com/kwen2501
Unblocking pytorch#161741 Pull Request resolved: pytorch#162035 Approved by: https://github.com/Skylion007, https://github.com/ngimel
Fixes pytorch#161722 Pull Request resolved: pytorch#161741 Approved by: https://github.com/kwen2501
Unblocking pytorch#161741 Pull Request resolved: pytorch#162035 Approved by: https://github.com/Skylion007, https://github.com/ngimel
Fixes pytorch#161722 Pull Request resolved: pytorch#161741 Approved by: https://github.com/kwen2501
Unblocking pytorch#161741 Pull Request resolved: pytorch#162035 Approved by: https://github.com/Skylion007, https://github.com/ngimel
Fixes pytorch#161722 Pull Request resolved: pytorch#161741 Approved by: https://github.com/kwen2501
Fixes #161722
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd