Skip to content

Conversation

kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Sep 3, 2025

[ghstack-poisoned]
kwen2501 added a commit that referenced this pull request Sep 3, 2025
ghstack-source-id: 34f7310
Pull-Request-resolved: #162035
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162035

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9432625 with merge base 524b78d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/h100-symm-mem oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category labels Sep 3, 2025
@kwen2501 kwen2501 requested a review from fegin September 3, 2025 01:44
@kwen2501
Copy link
Contributor Author

kwen2501 commented Sep 3, 2025

cc @yuankaichen-amd

@kwen2501 kwen2501 requested a review from ngimel September 3, 2025 03:56
@kwen2501
Copy link
Contributor Author

kwen2501 commented Sep 3, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 3, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Copy link
Collaborator

@ngimel ngimel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this is needed for ROCm CI but not for cuda?

@kwen2501
Copy link
Contributor Author

kwen2501 commented Sep 3, 2025

@ngimel No idea -- the code before and after should be essentially the same. I just remove the hardsetting of "0".

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@github-actions github-actions bot deleted the gh/kwen2501/227/head branch October 4, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/h100-symm-mem ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants