Fix critical null pointer bug in TransformerEncoder #165313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation in constructor to prevent num_layers <= 0 - Add runtime check before accessing self.layers[0] - Provide clear error messages instead of IndexError - Prevents production crashes in Transformer models Fixes potential IndexError when TransformerEncoder is created with num_layers=0 or when layers list becomes empty unexpectedly. The fix adds defensive programming practices: 1. Constructor validation prevents invalid initialization 2. Runtime validation prevents crashes during forward pass 3. Clear error messages help users understand the problem This addresses a critical bug that could cause production crashes in applications using TransformerEncoder with invalid parameters.
abhitorch81
requested review from
albanD,
jbschlosser and
mikaylagawarecki
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165313
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 50e714e with merge base 22b1710 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soulitzer
added
the
triaged
Contributor
Author
|
@soulitzer can you check on this? Thanks |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
Author
|
@malfet @Skylion007 Can you help on reviewing this? Thanks for the co-operation and open to changes and improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes potential IndexError when TransformerEncoder is created with num_layers=0 or when layers list becomes empty unexpectedly.
The fix adds defensive programming practices:
This addresses a critical bug that could cause production crashes in applications using TransformerEncoder with invalid parameters.
Fixes #165312