[MTIAGraph][Pytorch][2/n] Add binding for Python to C++, and hook for Pytorch to Fbcode #165963

andyanwang · 2025-10-21T03:41:52Z

Summary:
This diff is the binding and hook layer for MTIA Graph, including

binding between Python and C++
hook between Pytorch and mtia fbcode

Doc

Test Plan: Will be tested in the python implementation which will use the binding and hook

Differential Revision: D84457757

cc @egienvalue

pytorch-bot · 2025-10-21T03:41:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165963

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3b7017a with merge base f5543e3 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2025-10-21T03:42:01Z

@andyanwang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84457757.

Skylion007 · 2025-10-21T17:28:02Z

torch/csrc/mtia/Module.cpp

+
+  _MTIAGraph(bool keep_graph = false)
+      : handle_(at::detail::getMTIAHooks().mtiagraphCreate(keep_graph)) {}
+  ~_MTIAGraph() {}


Shouldn't this equal default?

… Pytorch to Fbcode (pytorch#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Reviewed By: chaos5958 Differential Revision: D84457757

… Pytorch to Fbcode (pytorch#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode {F1982920659} [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Reviewed By: chaos5958 Differential Revision: D84457757

malfet

LGTM

malfet · 2025-10-28T17:51:01Z

aten/src/ATen/detail/MTIAHooksInterface.h


-#include <c10/util/python_stub.h>
 #include <ATen/detail/AcceleratorHooksInterface.h>
+#include <c10/util/python_stub.h>


Why change the header order here (and may be move all c10 headers to one block)

I think it's done by lintrunner. I'll double check

malfet · 2025-10-28T17:51:20Z

aten/src/ATen/detail/MTIAHooksInterface.h

  }

-  virtual void setCurrentStream(const c10::Stream& /*stream*/ ) const {
+  virtual void setCurrentStream(const c10::Stream& /*stream*/) const {


Feels like could be done by separate commit

… Pytorch to Fbcode (#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode {F1982920659} [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Reviewed By: chaos5958 Differential Revision: D84457757

albanD

SGTM

… Pytorch to Fbcode (pytorch#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode {F1982920659} [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Reviewed By: chaos5958 Differential Revision: D84457757

facebook-github-bot · 2025-10-31T02:44:34Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2025-10-31T02:47:12Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

… Pytorch to Fbcode (#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode <img width="1780" height="754" alt="image" src="https://github.com/user-attachments/assets/31e24e5b-8324-42d8-8d3b-59536bc18340" /> [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Differential Revision: D84457757 Pull Request resolved: #165963 Approved by: https://github.com/malfet, https://github.com/albanD

Per suggestion from the previous PR(#165963), separating clang-format changes. Differential Revision: [D86031474](https://our.internmc.facebook.com/intern/diff/D86031474/) [ghstack-poisoned]

I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) [ghstack-poisoned]

I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) ghstack-source-id: 320301565 Pull Request resolved: #166806

Pull Request resolved: #166806 I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) ghstack-source-id: 320385344

…les" Per suggestion from the previous PR(#165963), separating clang-format changes. Differential Revision: [D86031474](https://our.internmc.facebook.com/intern/diff/D86031474/) cc egienvalue [ghstack-poisoned]

Per suggestion from the previous PR(#165963), separating clang-format changes. Differential Revision: [D86031474](https://our.internmc.facebook.com/intern/diff/D86031474/) cc egienvalue [ghstack-poisoned]

…troy graph C++ instance" I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) cc egienvalue [ghstack-poisoned]

…nstance" I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) cc egienvalue [ghstack-poisoned]

Per suggestion from the previous PR(#165963), separating clang-format changes. Differential Revision: [D86031474](https://our.internmc.facebook.com/intern/diff/D86031474/) Pull Request resolved: #166805 Approved by: https://github.com/Skylion007, https://github.com/albanD

…66806) I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) Pull Request resolved: #166806 Approved by: https://github.com/albanD ghstack dependencies: #166805

… Pytorch to Fbcode (pytorch#165963) Summary: This diff is the binding and hook layer for MTIA Graph, including 1. binding between Python and C++ 2. hook between Pytorch and mtia fbcode <img width="1780" height="754" alt="image" src="https://github.com/user-attachments/assets/31e24e5b-8324-42d8-8d3b-59536bc18340" /> [Doc](https://docs.google.com/document/d/1Q3xdZAIqhBvuy2HxGDfJyXVmxYXUEeYSZSwsp7bcJF8/edit?tab=t.osb46a42t6wb#heading=h.ayp9tkk08x00) Test Plan: Will be tested in the python implementation which will use the binding and hook Differential Revision: D84457757 Pull Request resolved: pytorch#165963 Approved by: https://github.com/malfet, https://github.com/albanD

Per suggestion from the previous PR(#165963), separating clang-format changes. Differential Revision: [D86031474](https://our.internmc.facebook.com/intern/diff/D86031474/) Pull Request resolved: #166805 Approved by: https://github.com/Skylion007, https://github.com/albanD

…66806) I missed this API for MTIAGraph in D84457757(#165963) Differential Revision: [D86026706](https://our.internmc.facebook.com/intern/diff/D86026706/) Pull Request resolved: #166806 Approved by: https://github.com/albanD ghstack dependencies: #166805

andyanwang requested a review from egienvalue as a code owner October 21, 2025 03:41

meta-codesync bot added fb-exported meta-exported labels Oct 21, 2025

andyanwang added topic: not user facing topic category module: mtia Device MTIA related issues labels Oct 21, 2025

Skylion007 reviewed Oct 21, 2025

View reviewed changes

andyanwang force-pushed the export-D84457757 branch from e8cd700 to ffdb0f6 Compare October 22, 2025 19:08

andyanwang force-pushed the export-D84457757 branch from ffdb0f6 to 0a0ef5e Compare October 22, 2025 19:41

andyanwang requested review from albanD and malfet October 22, 2025 19:43

andyanwang force-pushed the export-D84457757 branch from 0a0ef5e to 991cc2b Compare October 22, 2025 20:53

andyanwang requested a review from Skylion007 October 28, 2025 17:29

malfet approved these changes Oct 28, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 28, 2025

malfet reviewed Oct 28, 2025

View reviewed changes

andyanwang force-pushed the export-D84457757 branch from 991cc2b to c65c76c Compare October 28, 2025 21:04

andyanwang force-pushed the export-D84457757 branch from c65c76c to be99ded Compare October 30, 2025 18:16

albanD approved these changes Oct 30, 2025

View reviewed changes

andyanwang force-pushed the export-D84457757 branch from be99ded to 3b7017a Compare October 30, 2025 21:26

pytorchmergebot added the merging label Oct 31, 2025

pytorchmergebot added the Merged label Oct 31, 2025

pytorchmergebot closed this in d3be06c Oct 31, 2025

pytorchmergebot removed the merging label Oct 31, 2025

andyanwang mentioned this pull request Nov 1, 2025

[easy][MTIAGraph][Pytorch] clang-format files #166805

Closed

andyanwang mentioned this pull request Nov 1, 2025

[MTIAGraph][Pytorch][2.1/n] Add API to destroy graph C++ instance #166806

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MTIAGraph][Pytorch][2/n] Add binding for Python to C++, and hook for Pytorch to Fbcode #165963

[MTIAGraph][Pytorch][2/n] Add binding for Python to C++, and hook for Pytorch to Fbcode #165963

Uh oh!

andyanwang commented Oct 21, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Oct 21, 2025 •

edited

Loading

Uh oh!

meta-codesync bot commented Oct 21, 2025

Uh oh!

Skylion007 Oct 21, 2025

Uh oh!

malfet left a comment

Uh oh!

malfet Oct 28, 2025

Uh oh!

andyanwang Oct 28, 2025

Uh oh!

malfet Oct 28, 2025

Uh oh!

albanD left a comment

Uh oh!

facebook-github-bot commented Oct 31, 2025

Uh oh!

pytorchmergebot commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[MTIAGraph][Pytorch][2/n] Add binding for Python to C++, and hook for Pytorch to Fbcode #165963

[MTIAGraph][Pytorch][2/n] Add binding for Python to C++, and hook for Pytorch to Fbcode #165963

Uh oh!

Conversation

andyanwang commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165963

✅ No Failures

Uh oh!

meta-codesync bot commented Oct 21, 2025

Uh oh!

Skylion007 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

malfet Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

andyanwang Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

malfet Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Oct 31, 2025

Uh oh!

pytorchmergebot commented Oct 31, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andyanwang commented Oct 21, 2025 •

edited

Loading

pytorch-bot bot commented Oct 21, 2025 •

edited

Loading