Skip to content

[BE] Use [[maybe_unused]] #166865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[BE] Use [[maybe_unused]] #166865

wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Nov 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Instead of (void) foo; // Unused parameter trick, as this is a C++17 standard feature

Will replace further repetitions of the same pattern soon after

@malfet
Update
82a9526 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166865

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit ce9f0aa with merge base 3f54010 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Nov 3, 2025
@malfet
[BE] Use [[maybe_unsued]]
fec08d0 
Instead of `(void) foo; // Unused parameter` trick, as this is a C++17
standard feature

ghstack-source-id: 9c55f0c
Pull Request resolved: #166865
@malfet malfet added the topic: not user facing topic category label Nov 3, 2025
mikaylagawarecki
mikaylagawarecki approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thank you!

@malfet
Update
ce9f0aa 
[ghstack-poisoned]
@malfet malfet requested a review from janeyx99 as a code owner November 3, 2025 18:27
malfet added a commit that referenced this pull request Nov 3, 2025
@malfet
[BE] Use [[maybe_unsued]]
0e86749 
Instead of `(void) foo; // Unused parameter` trick, as this is a C++17
standard feature

ghstack-source-id: c90a829
Pull Request resolved: #166865
@Skylion007 Skylion007 added the better-engineering Relatively self-contained tasks for better engineering contributors label Nov 3, 2025
@Skylion007
Copy link
Collaborator

Skylion007 commented Nov 3, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 3, 2025
@Skylion007 Skylion007 changed the title [BE] Use [[maybe_unsued]] [BE] Use [[maybe_unused]] Nov 3, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 3, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mikaylagawarecki
mikaylagawarecki requested changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, fyi I'm reverting my own diff that introduced this (see context on T243306212) so can we please hold off on landing this for now (or I will merge it into the reland), whichever works. I just canelled the merge workflow, I'm sorry about that!

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 3, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@malfet
Copy link
Contributor Author

malfet commented Nov 3, 2025

@mikaylagawarecki no worries, waiting for revert, feel free to just incorporate those changes

mikaylagawarecki
mikaylagawarecki approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up forward fixing instead of reverting my changes, so this is good to land!

@mikaylagawarecki
Copy link
Contributor

mikaylagawarecki commented Nov 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @Skylion007 @pytorchmergebot @mikaylagawarecki @janeyx99