Follow up to adaptive_max_pool2d() port #19738
Conversation
pytorchbot
added
module: cuda
skrah
added
module: nn
|
A more condensed version of dispatching is possible (like in |
skrah
changed the title
|
@xmnlab I know you are busy, but it would be great if you can review when you have time. |
|
@skrah sure! I will review that now :) |
There was a problem hiding this comment.
LGTM! thanks @skrah !
I have just one question related to the function naming, you use adaptive_max_pool2d_single_out_frame
the only file I found that uses single for the function name uses fractional_max_pool2d_out_single_batch_frame
but other file uses reflection_pad1d_out_loop
I am curious about if there is one standard for naming here.
|
Thanks @xmnlab! I don't know if there is a naming convention, but indeed |
|
@ezyang I think this one should be ready now for your review, thanks! |
|
@ezyang could you review this PR? |
|
oh @skrah sorry .. I didn't see you have already mentioned |
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This is a follow up PR for #19409. Pull Request resolved: pytorch/pytorch#19738 Differential Revision: D15103231 Pulled By: ezyang fbshipit-source-id: 11c9fec641b389906b8accd22504a683331fa6ec
Summary: This is a follow up PR for pytorch#19409. Pull Request resolved: pytorch#19738 Differential Revision: D15103231 Pulled By: ezyang fbshipit-source-id: 11c9fec641b389906b8accd22504a683331fa6ec
5 participants
This is a follow up PR for #19409.