[Versioning] Migrate Hydra entry points to version_base 1.3 for Hydra 1.4 readiness - #4056
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4056
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Thanks for putting this together. The migration is broadly consistent: all 57 One item to address is propagating the
In an existing environment, an unconstrained requirement can leave Hydra 1.1 installed. The new One broader, non-blocking observation: needing to repeat There is also a broader compatibility choice to make. The new requirement is I suggest choosing one of these approaches:
The current state—allowing Hydra 1.4 without testing it—leaves users exposed to incompatibilities outside the scope of |
|
@omry I just temporarily constrained the dep for now. once the 1.4 is finalized and the trl compability has been validated, I will draft a follow up pr for the updated dep. |
2060184 to
15564e8
Compare
3eb7179 to
6373ab5
Compare
vmoens
left a comment
There was a problem hiding this comment.
LGTM let's wait till the CI has finished running
Can you look at the PR once more, I made some edits, just want to check they make sense
The expert-iteration and GRPO entry points moved from `version_base=None` to `"1.3"`. `version_base=None` selects Hydra's 1.1 compatibility defaults, which include `hydra.job.chdir=True`, so those four recipes silently stopped chdir'ing into their run directory -- the regression this PR avoids everywhere else by adding an explicit `hydra.job.chdir: true`. Their configs already declare a `hydra:` block (`run.dir` / `sweep.dir`), so `job.chdir` goes inside it rather than being appended as a second top-level `hydra:` key. Also aligns docs/requirements.txt with the `hydra-core>=1.3,<1.4` bound already applied to the `dev` and `utils` extras in pyproject.toml. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
6373ab5 to
b77dac5
Compare
Prepares Hydra entry points for Hydra 1.4 (#4055)
hydra.mainentry points and compose-API test calls now passversion_base="1.3"(previously"1.1",None, or unset).hydra.job.chdir: true, keeping run-dir behavior unchanged.>=1.3in pyproject.toml.Draft until Hydra 1.4 is released.