[BugFix] Stabilize cross-format checkpoint recovery - #4252
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4252
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7f83d31 with merge base 5380357 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cross-format checkpoint recovery when two manifests have identical creation timestamps, as observed on Windows. Rotation now uses filesystem modification nanoseconds before filename ordering, so interrupted replacements keep the newly written checkpoint regardless of container format.
The existing interrupted-replacement test now forces equal creation times and distinct write order.
Validation:
Observed in: https://github.com/pytorch/rl/actions/runs/34016957895/job/101452018472