Skip to content

Conversation

@tcbegley
Copy link
Contributor

Description

Docs build was failing because git-subtree is not installed in the runner.

Rather than installing , we just use a clone instead and clean up the nested Git repo.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2022
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit b21776f into pytorch:main Nov 22, 2022
@tcbegley tcbegley deleted the fix-docs-build branch November 22, 2022 10:39
vmoens added a commit that referenced this pull request Nov 23, 2022
* amend

* [BugFix] ConvNet forward method with tensors of more than 4 dimensions (#686)

* cnn forward fix

* more general code

* cnn testing

* precommit run check

* convnet tests

* [Feature] add `standard_normal` for RewardScaling (#682)

* Add standard_normal

* give attribute access

* Update standard_normal

* Update tests

* Fix tests

* Address in-place scaling of reward

* Improvise tests

* [Feature] Jumanji envs (#674)

* amend

* [Feature] Default collate_fn (#688)

* init

* amend

* amend

* [BugFix] Fix Examples (#687)

* amend

* [Refactoring] Replace direct gym version checks with decorated functions (#691)

* [Refactoring] Replace gym version checking with decorated functions (#)

Initial commit. Only tests.

* Refactoring in gym.py

* More refactoring in gym.py

* Completed refactoring

* amend

* amend

* Version 0.0.3 (#696)

* [Docs] Host TensorDict docs inside TorchRL docs (#693)

* Pull tensordict docs into TorchRL docs

* Add banner for tensordict docs

* [BugFix] Fix docs build (#698)

* [BugFix] Proper error messages for orphan transform creation (#697)

* amend

* [Feature] Append, init and insert transforms in ReplayBuffer (#695)

* lint

Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com>
Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com>
Co-authored-by: yingchenlin <yc.jon.lin@gmail.com>
Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com>
Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Co-authored-by: Alan Schelten <alan@schelten.net>
vmoens added a commit that referenced this pull request Jan 5, 2023
* init

* tests1

* run examples in tests

* [Feature] MPPI Planner (#694)

* amend

* [BugFix] ConvNet forward method with tensors of more than 4 dimensions (#686)

* cnn forward fix

* more general code

* cnn testing

* precommit run check

* convnet tests

* [Feature] add `standard_normal` for RewardScaling (#682)

* Add standard_normal

* give attribute access

* Update standard_normal

* Update tests

* Fix tests

* Address in-place scaling of reward

* Improvise tests

* [Feature] Jumanji envs (#674)

* amend

* [Feature] Default collate_fn (#688)

* init

* amend

* amend

* [BugFix] Fix Examples (#687)

* amend

* [Refactoring] Replace direct gym version checks with decorated functions (#691)

* [Refactoring] Replace gym version checking with decorated functions (#)

Initial commit. Only tests.

* Refactoring in gym.py

* More refactoring in gym.py

* Completed refactoring

* amend

* amend

* Version 0.0.3 (#696)

* [Docs] Host TensorDict docs inside TorchRL docs (#693)

* Pull tensordict docs into TorchRL docs

* Add banner for tensordict docs

* [BugFix] Fix docs build (#698)

* [BugFix] Proper error messages for orphan transform creation (#697)

* amend

* [Feature] Append, init and insert transforms in ReplayBuffer (#695)

* lint

Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com>
Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com>
Co-authored-by: yingchenlin <yc.jon.lin@gmail.com>
Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com>
Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Co-authored-by: Alan Schelten <alan@schelten.net>

* lint

Co-authored-by: albertbou92 <albertbou92@users.noreply.github.com>
Co-authored-by: Aditya Gandhamal <61016383+adityagandhamal@users.noreply.github.com>
Co-authored-by: yingchenlin <yc.jon.lin@gmail.com>
Co-authored-by: Sergey Ordinskiy <113687736+ordinskiy@users.noreply.github.com>
Co-authored-by: Tom Begley <tomcbegley@gmail.com>
Co-authored-by: Alan Schelten <alan@schelten.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants