Skip to content

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Jan 1, 2023

Description

Solves some missing references and enriches the knowledge base.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 1, 2023
@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #782 (b610db3) into main (00424b7) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
+ Coverage   88.72%   88.73%   +0.01%     
==========================================
  Files         123      123              
  Lines       21033    21033              
==========================================
+ Hits        18661    18664       +3     
+ Misses       2372     2369       -3     
Flag Coverage Δ
habitat-gpu 24.82% <ø> (ø)
linux-brax 29.44% <ø> (ø)
linux-cpu 85.27% <ø> (ø)
linux-gpu 86.18% <ø> (+0.01%) ⬆️
linux-jumanji 30.22% <ø> (ø)
linux-outdeps-gpu 72.11% <ø> (ø)
linux-stable-cpu 85.12% <ø> (ø)
linux-stable-gpu 85.82% <ø> (+0.01%) ⬆️
linux_examples-gpu 42.83% <ø> (ø)
macos-cpu 85.02% <ø> (ø)
olddeps-gpu 76.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchrl/envs/vec_env.py 69.42% <0.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

TransformedEnv
RewardClipping
Resize
BinarizeReward
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious how are these ordered now ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the two classes that you must know about, then the rest in alphabetic order

@vmoens vmoens added the documentation Improvements or additions to documentation label Jan 3, 2023
# Conflicts:
#	docs/source/reference/envs.rst
@vmoens vmoens merged commit 45b5d72 into main Jan 3, 2023
@vmoens vmoens deleted the better_doc branch January 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants