add functions to test API compatibility changes #1221
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
dagitses
changed the title
dagitses
changed the title
dagitses
force-pushed
the
pr1221
branch
5 times, most recently
from
d74387f to
d0cbc71
Compare
dagitses
force-pushed
the
pr1221
branch
2 times, most recently
from
5c3f571 to
ea013af
Compare
seemethere
approved these changes
Dec 6, 2022
osalpekar
approved these changes
Dec 6, 2022
This was referenced Dec 8, 2022
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1298). * #1291 * #1221 * #1304 * #1303 * #1302 * #1301 * #1299 * __->__ #1298 track the line number where a parameter is defined Summary: This will allow us to propagate the line number to violations. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1299). * #1291 * #1221 * #1304 * #1303 * #1302 * #1301 * __->__ #1299 * #1298 use the parameter line number for the moved param check Test Plan: Verified in test PR.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1301). * #1291 * #1221 * #1304 * #1303 * #1302 * __->__ #1301 * #1299 * #1298 extract requiredness check to a single function Summary: This was previously duplicated across two checks. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1302). * #1291 * #1221 * #1304 * #1303 * __->__ #1302 simplify parameter reordering check Summary: The previous check was very noisy when a parameter was added. This will allow us to simplify it down the line. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1304). * #1291 * #1221 * __->__ #1304 * #1303 no longer track position for each parameter Summary: This can be tracked by its order in the Parameters object. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1303). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * #1304 * __->__ #1303 use difflib to better detect changes to positional parameters Summary: Fundamentally, for parameters that may be passed positionally, we care about which from the previous function correspond to the later function. Diffing is a clean way to do that. Test Plan: Rely on CI. Verify end-to-end in GitHub UI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1312). * #1291 * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * __->__ #1312 [Reland] no longer track position for each parameter Summary: This can be tracked by its order in the Parameters object. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1315). * #1291 * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * __->__ #1315 test and fix that adding optional parameters is ok Test Plan: Rely on CI.
dagitses
force-pushed
the
pr1221
branch
5 times, most recently
from
bb298b9 to
b6e864f
Compare
added 5 commits
December 21, 2022 14:05
Summary: TDD Test Plan: Verified tests fail.
Summary: We are able to loosen this check, to support adding forwarding functions. Test Plan: Rely on CI.
Summary: This will be a common recipe when renaming or moving a function to another file. Leave a breadcrumb to call it. Test Plan: TDD: verified test is broken
…iadic args Summary: The before version having variadic args is meaningless. Test Plan: Verified broken test is fixed.
Summary: DO NOT MERGE
This was referenced Dec 21, 2022
Contributor
|
Hi @dagitses! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.
add functions to test API compatibility changes
Summary: DO NOT MERGE