add a positional parameter without a default #1225
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2022
Draft
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Dec 8, 2022
dagitses
force-pushed
the
pr1225
branch
2 times, most recently
from
2689334 to
4551db9
Compare
dagitses
force-pushed
the
pr1225
branch
2 times, most recently
from
474b783 to
d06fdb2
Compare
dagitses
force-pushed
the
pr1225
branch
2 times, most recently
from
5343238 to
c08378c
Compare
dagitses
added a commit
that referenced
this pull request
Dec 10, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1252). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * #1256 * #1255 * #1253 * __->__ #1252 move the git fetch into the checker program Summary: When we push this to other repos, we'll want as much of the implementation embedded in the binary as possible. Test Plan: Rely on CI.
dagitses
added a commit
that referenced
this pull request
Dec 10, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1253). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * #1256 * #1255 * __->__ #1253 * #1252 group and suppress the fetch output by default Summary: This is noisy and uninteresting: hide it. Test Plan: Verify visually in CI.
dagitses
added a commit
that referenced
this pull request
Dec 10, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1255). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * #1256 * __->__ #1255 * #1253 * #1252 add support for suppressing api compatibility check violations Summary: This will allow users to say that their changes are OK. Test Plan: Verify with sample PR.
dagitses
added a commit
that referenced
this pull request
Dec 10, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1256). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * __->__ #1256 downgrade severity from warning to notice when suppressed Summary: We wish to still see violations when suppressing, but they should be at info level, rather than warning. Test Plan: Verify with a sample PR. #suppress-api-compatibility-check because the modified function is internal to the checker itself.
dagitses
force-pushed
the
pr1225
branch
2 times, most recently
from
8c0ce1b to
ad6a8d5
Compare
This was referenced Dec 16, 2022
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1303). * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * #1304 * __->__ #1303 use difflib to better detect changes to positional parameters Summary: Fundamentally, for parameters that may be passed positionally, we care about which from the previous function correspond to the later function. Diffing is a clean way to do that. Test Plan: Rely on CI. Verify end-to-end in GitHub UI.
This was referenced Dec 16, 2022
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1312). * #1291 * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * __->__ #1312 [Reland] no longer track position for each parameter Summary: This can be tracked by its order in the Parameters object. Test Plan: Rely on CI.
Summary: DO NOT MERGE
dagitses
added a commit
that referenced
this pull request
Dec 16, 2022
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/1315). * #1291 * #1227 * #1226 * #1225 * #1224 * #1223 * #1221 * __->__ #1315 test and fix that adding optional parameters is ok Test Plan: Rely on CI.
Contributor
|
Hi @dagitses! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.
add a positional parameter without a default
Summary: DO NOT MERGE