Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Sep 26, 2024

Summary: Unbreak test-cpu-eval-sanity-check-* CI jobs

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1215

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (18 Unrelated Failures)

As of commit 0917c14 with merge base ae3555b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 26, 2024
@larryliu0820 larryliu0820 force-pushed the fix_eval_ci branch 2 times, most recently from cb7bc1d to c5fc5dc Compare September 26, 2024 08:02
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link
Contributor

@byjlw byjlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need the big machine here?

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820
Copy link
Contributor Author

do we still need the big machine here?

Ideally all CI jobs should use PyTorch test infra workflows, meaning they should have this line:

    uses: pytorch/test-infra/.github/workflows/linux_job.yml@main

It provides ssh functionality automatically and probably other benefits. However it's not critical to fix CI so reverting it

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@larryliu0820 larryliu0820 force-pushed the fix_eval_ci branch 3 times, most recently from 62d7630 to ecb5664 Compare September 26, 2024 17:48
@larryliu0820 larryliu0820 force-pushed the fix_eval_ci branch 5 times, most recently from 1d24d74 to e631454 Compare September 26, 2024 18:32
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
larryliu0820 and others added 3 commits September 26, 2024 12:04
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@Jack-Khuu
Copy link
Contributor

Landing this PR as-is to unblock + jobs stuck in queue

Will have separate PR for any other fixes

@Jack-Khuu Jack-Khuu merged commit ec7b510 into main Sep 26, 2024
33 of 51 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants