Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@byjlw
Copy link
Contributor

@byjlw byjlw commented Jul 16, 2024

the validator only returns the first violation it finds. There are a whole bunch more.

@byjlw byjlw requested a review from Jack-Khuu July 16, 2024 17:35
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/905

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8faaf00 with merge base 0097b3c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 16, 2024
@Jack-Khuu
Copy link
Contributor

Can you add the validator command in the comments?

@byjlw byjlw merged commit 4ca7f49 into main Jul 16, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)
malfet pushed a commit that referenced this pull request Jul 17, 2024
* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
vmpuri pushed a commit that referenced this pull request Jul 17, 2024
* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo
malfet pushed a commit that referenced this pull request Jul 17, 2024
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants