Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

this should be the final one #911

Merged
merged 1 commit into from
Jul 17, 2024
Merged

this should be the final one #911

merged 1 commit into from
Jul 17, 2024

Conversation

@byjlw
Copy link
Contributor

@byjlw byjlw commented Jul 16, 2024

No description provided.

@byjlw byjlw requested review from Jack-Khuu and malfet July 16, 2024 22:22
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/911

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cda86ed with merge base 4ca7f49 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 16, 2024
@byjlw byjlw merged commit ec0377c into main Jul 17, 2024
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
this should be the final one (#911)
9c0f7c1
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
139d2ac 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
621d548 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
4d1f6d5 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
a70f4ba 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
453c16a 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
malfet pushed a commit that referenced this pull request Jul 17, 2024
@byjlw @malfet
need license header on every file (#904)
6372e36 
Add license header to files (#905)

* need license header on every file

* apparently the validator only reports the first violation it finds not all of them

* typeo

don't put the license on these files (#909)

add license to source files (#910)

this should be the final one (#911)
@malfet malfet deleted the more-license-headers branch July 17, 2024 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@malfet malfet Awaiting requested review from malfet

1 more reviewer

@Jack-Khuu Jack-Khuu Jack-Khuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@byjlw @Jack-Khuu @facebook-github-bot