Include missing dependencies in setup.py #3611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackCaoG
approved these changes
May 25, 2022
Collaborator
|
Do we need this to be backported to 1.12? |
Collaborator
Author
|
This issue would have been going on through several releases, but it should be safe to cherry-pick this into 1.12 |
yeounoh
approved these changes
May 25, 2022
Contributor
yeounoh
left a comment
yeounoh
left a comment
There was a problem hiding this comment.
LGTM, thanks @will-cromar
wonjoo-wj
pushed a commit
that referenced
this pull request
Jun 14, 2022
wonjoo-wj
added a commit
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absl-pyandcloud-tpu-clientare both required forxla_dist.Bonus: fix typo
litbpu->libtpu