The Python GC does not immediately release the collected objects, so … - #49
Merged
Conversation
dlibenzi
commented
Dec 8, 2018
| return self->mul(other); | ||
| }, | ||
| py::arg("other")) | ||
| .def( |
Collaborator
Author
There was a problem hiding this comment.
Not sure why it does this.
I just ran clang-format-buffer :|
dlibenzi
force-pushed
the
wait_for_handle_release
branch
2 times, most recently
from
December 9, 2018 00:29
8781202 to
7244ac6
Compare
dlibenzi
commented
Dec 9, 2018
dlibenzi
force-pushed
the
wait_for_handle_release
branch
2 times, most recently
from
December 9, 2018 20:05
09d98f6 to
4e9b49d
Compare
asuhan
suggested changes
Dec 10, 2018
asuhan
left a comment
asuhan
left a comment
Contributor
There was a problem hiding this comment.
Mostly ok, just concerns around naming.
…we need to wait for it to happen before heading out.
dlibenzi
force-pushed
the
wait_for_handle_release
branch
from
December 10, 2018 15:12
4e9b49d to
fabf380
Compare
asuhan
approved these changes
Dec 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…we need to wait for it to happen before heading out.