Store credentials file with restricted 600 perms - #368
Merged
Conversation
RealCLanger
requested changes
Jul 25, 2026
RealCLanger
left a comment
RealCLanger
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense but the change still has an error. See checks. Please update and fix.
KevSlashNull
force-pushed
the
creds-rw-user-only
branch
from
July 25, 2026 16:04
12d2147 to
a722dc5
Compare
This adds a `chmod` that changes the permissions of the credentials file `~/.pytr/credentials` to only allow reading and writing by the user and not the group or other users. SSH does something similar where it requires that private keys must be set to 600 instead of the default 644 mode.
KevSlashNull
force-pushed
the
creds-rw-user-only
branch
from
July 25, 2026 16:05
a722dc5 to
3374274
Compare
Contributor
Author
|
ruff, oops. ruff checks pass now, thanks @RealCLanger. |
RealCLanger
approved these changes
Jul 26, 2026
RealCLanger
left a comment
RealCLanger
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
chmodthat changes the permissions of the credentials file~/.pytr/credentialsto only allow reading and writing by the user and not thegroup or other users.
SSH does something similar where it requires that private keys must be set to
600 instead of the default 644 mode.