Skip to content

Add a unit test for the CO2 corrector#3371

Open
gerritholl wants to merge 2 commits intopytroll:mainfrom
gerritholl:test-co2-cerroctor
Open

Add a unit test for the CO2 corrector#3371
gerritholl wants to merge 2 commits intopytroll:mainfrom
gerritholl:test-co2-cerroctor

Conversation

@gerritholl
Copy link
Copy Markdown
Member

Add a unit test for satpy.modifiers.atmosphere.CO2Corrector.

Also move other atmospheric modifier unit tests to their own test module.

  • Tests added

Mode tests for modifiers in modifiers/atmosphere.py to their own test
module in tests/modifier_tests/test_atmosphere.py.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.35%. Comparing base (6c571f2) to head (bf75088).
⚠️ Report is 77 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3371   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         466      467    +1     
  Lines       59083    59106   +23     
=======================================
+ Hits        56931    56954   +23     
  Misses       2152     2152           
Flag Coverage Δ
behaviourtests 3.58% <0.00%> (-0.01%) ⬇️
unittests 96.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gerritholl
Copy link
Copy Markdown
Member Author

CodeScene is complaining about code that I moved but did not otherwise touch. An attempt to suppress the finding still fails with "Error occurred while suppressing! Please try again." I don't know if the suppression has ever worked (for me it never has).

@djhoese
Copy link
Copy Markdown
Member

djhoese commented Apr 8, 2026

Maybe I'm misunderstanding, but we don't want to suppress what CodeScene is finding since it is an actual problem. We just won't let it stop this PR from being merged as it isn't a new issue you are adding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants