Skip to content

pipenv: Set environment variables via .env#516

Merged
encukou merged 1 commit intopyvec:masterfrom
hroncok:env_pipfile
Jan 29, 2019
Merged

pipenv: Set environment variables via .env#516
encukou merged 1 commit intopyvec:masterfrom
hroncok:env_pipfile

Conversation

@hroncok
Copy link
Copy Markdown
Member

@hroncok hroncok commented Jan 28, 2019

(Maybe) fixes #515

This works on Linux. I have not tested it on Windows and I have no idea if it works there.
If anyone would be able to check that, it would be great.

@hroncok hroncok requested a review from encukou January 28, 2019 22:58
@hroncok
Copy link
Copy Markdown
Member Author

hroncok commented Jan 28, 2019

(Confirmed that the changes make it possible to run the commands on Windows.)

@encukou
Copy link
Copy Markdown
Member

encukou commented Jan 29, 2019

Do you need to install python-dotenv on Windows? It works on Linux without it, though it does give a warning.

@encukou encukou merged commit 420a094 into pyvec:master Jan 29, 2019
@hroncok
Copy link
Copy Markdown
Member Author

hroncok commented Jan 29, 2019

The warning is from flask. To my understanding:

  • pipenv has python-dotenv and uses it
  • python-dotenv is not installed in our virtual environment, hence Flask warns that it sees the file

The warning is harmless, we don't need Flask to load this variable. However we might want to install it just to silence it? Not sure.

@hroncok hroncok deleted the env_pipfile branch January 29, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pipenv commands are broken on Windows: 'env' is not recognized

2 participants